search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
249 stars 72 forks source link

Three unit tests are failing on Python 3.12 #381

Closed whitslack closed 1 year ago

whitslack commented 1 year ago

All unit tests (except those skipped) pass on Python 3.11.3, but three are failing on Python 3.12.0 beta 1.

If it's relevant, this is with Twisted 22.10.0.

===============================================================================
[SKIPPED]
No GeoIP in github-actions

test.test_util.TestGeoIpDatabaseLoading.test_return_geoip_object
===============================================================================
[SKIPPED]
Doesn't work in PYPY, Py3

test.test_util_imports.TestImports.test_no_GeoIP
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/txtorcon-23.5.0/work/txtorcon-23.5.0/test/test_torstate.py", line 1296, in test_build_circuit
    self.assertEqual(len(self.flushWarnings()), 1)
  File "/usr/lib/python3.12/site-packages/twisted/trial/_synctest.py", line 441, in assertEqual
    super().assertEqual(first, second, msg)
  File "/usr/lib/python3.12/unittest/case.py", line 885, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.12/unittest/case.py", line 878, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 3 != 1

test.test_torstate.StateTests.test_build_circuit
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/txtorcon-23.5.0/work/txtorcon-23.5.0/test/test_torstate.py", line 1332, in test_build_circuit_final_callback
    self.assertEqual(len(self.flushWarnings()), 1)
  File "/usr/lib/python3.12/site-packages/twisted/trial/_synctest.py", line 441, in assertEqual
    super().assertEqual(first, second, msg)
  File "/usr/lib/python3.12/unittest/case.py", line 885, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.12/unittest/case.py", line 878, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 5 != 1

test.test_torstate.StateTests.test_build_circuit_final_callback
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/txtorcon-23.5.0/work/txtorcon-23.5.0/test/test_torstate.py", line 1480, in test_build_circuit_not_timedout
    self.assertEqual(len(self.flushWarnings()), 1)
  File "/usr/lib/python3.12/site-packages/twisted/trial/_synctest.py", line 441, in assertEqual
    super().assertEqual(first, second, msg)
  File "/usr/lib/python3.12/unittest/case.py", line 885, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python3.12/unittest/case.py", line 878, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: 7 != 1

test.test_torstate.StateTests.test_build_circuit_not_timedout
-------------------------------------------------------------------------------
Ran 682 tests in 2.863s

FAILED (skips=2, failures=3, successes=677)