meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
249 stars 72 forks source link

Remove Unused Dependency: Incremental #388

Closed gdrosos closed 1 year ago

gdrosos commented 1 year ago

Summary

This pull request removes the unused dependency incremental from the requirements.txt and doc-requirements.txt configuration files. The removal of this dependency is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The incremental library was first introduced to the project in 0a1fc13. However, in #234, the usage of incremental.Version was substituted with a custom _Version class. This internal implementation effectively replaced the functionalities that were previously sourced from the library. Given this, the incremental dependency appears to be extraneous and isn't required anymore. Removing this unused dependency reduces the overall footprint of the application, mitigating potential security risks, and simplifying the dependency management process.

Changes

Impact

coveralls commented 1 year ago

Coverage Status

coverage: 99.574%. remained the same when pulling 75d4f5a763153d0f5d9d4d8c6da0c1ea0c7a83fa on gdrosos:main into 21375a3b0b5df85d067d5e5cc2cd27e1c92ace53 on meejah:main.

meejah commented 1 year ago

Great, thanks!