search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

remove usage of "six" #396

Closed a-detiste closed 7 months ago

a-detiste commented 7 months ago

https://github.com/meejah/txtorcon/issues/395

meejah commented 7 months ago

hmm, looks like maybe some dependencies need to be updated for CI to pass? I'll take a look

meejah commented 7 months ago

Hmm, how am I supposed to "edit this PR"? (i.e. it says " Maintainers are allowed to edit this pull request. ")

(I tried pushing to your remote, which I didn't really expect to work, and it didn't!)

In tox.ini I added coverage < 7.0.0 because coverage changed something and coverage-lcov doesn't work with it ....

a-detiste commented 7 months ago

Hmm, how am I supposed to "edit this PR"? (i.e. it says " Maintainers are allowed to edit this pull request. ")

I have no idea. I will cherry pick 964a2d9a9498b8943c9060e8bfc38ba0dc5e36d4

meejah commented 7 months ago

I also just merged a fix to main ... (edit:oh you're talking about that one sorry)

coveralls commented 7 months ago

Coverage Status

coverage: 99.689% (+0.1%) from 99.574% when pulling c0b6dc1f02c35ac7045fb443e532ce404a2adbad on a-detiste:main into 585d7b029d8362b1260100da1e182a21d1bacb8c on meejah:main.

meejah commented 7 months ago

okay, well I can't explain why coveralls and/or GHA didn't like this when it was "your" PR ... but I merged it as #398 so thanks a lot!

a-detiste commented 7 months ago

You're welcome