search

meekm / LoRaSoundkit

This Soundkit sensor measures continuously audible sound by analyzing the data using FFT
19 stars 5 forks source link

Two changes #3

Closed bvmensvoort closed 3 years ago

bvmensvoort commented 3 years ago

Thanks for all the materials online and for all the efforts put in! I tried to make one myself and succeeded. My first ESP32 project! I had to make some small adjustments to the code though, and I wanted to share these. There are probably much neater solutions than these, but for now they work.

The first one is my code wouldn't compile, because of the error message: "add12bitsToBuf is not defined" Luckily moving the code solves this issue.

Second, I noticed that one of my two SoundKits started to give strange min/max readings. These values became the same value as the average. The spectrum readings seemed to still be okay. After changing the code it didn't occur anymore.

Good luck with next steps of the project!

meekm commented 3 years ago

Bram, thanks for your enhancement

meekm commented 3 years ago

Hello Bram,

Thanks for your contribution. I merged your changes in the main branch.

Kind regards Marcel

Op zo 16 mei 2021 om 11:28 schreef Bram van Mensvoort < @.***>:

Thanks for all the materials online and for all the efforts put in! I tried to make one myself and succeeded. My first ESP32 project! I had to make some small adjustments to the code though, and I wanted to share these. There are probably much neater solutions than these, but for now they work.

The first one is my code wouldn't compile, because of the error message: "add12bitsToBuf is not defined" Luckily moving the code solves this issue.

Second, I noticed that one of my two SoundKits started to give strange min/max readings. These values became the same value as the average. The spectrum readings seemed to still be okay. After changing the code it didn't occur anymore.

Good luck with next steps of the project!

You can view, comment on, or merge this pull request online at:

https://github.com/meekm/LoRaSoundkit/pull/3 Commit Summary

  • Move function to fix error message
  • Fix min/max to be the same as the average after a while

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/meekm/LoRaSoundkit/pull/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIZCIKL2DZQZVMMLKTSNUDTN6F5PANCNFSM446XRINQ .