search

meekrosoft / fff

A testing micro framework for creating function test doubles
Other
749 stars 163 forks source link

Fix gtest dependency by using FetchContent #120

Closed jakub-dudarewicz closed 1 year ago

jakub-dudarewicz commented 1 year ago

The current cmake configuration in fff is lacking, because it adds its own version of gtest, which might collide with a version of gtest provded by the user of the fff library. By using FetchContent, we can resolve this collision.

With this change one can FetchContent fff itself and override the gtest version used by it, to maintain consistency of dependencies used on all levels.

jakub-dudarewicz commented 1 year ago

@meekrosoft - would you be willing to merge this PR? This makes it way easier to include fff in modern CMake projects.

vhlushch commented 1 year ago

It would be great if this was merged 👍

wulfgarpro commented 1 year ago

@jakub-dudarewicz, please update buildandtest and anything relevant in README.md.

jakub-dudarewicz commented 1 year ago

@wulfgarpro, thanks for the review. I updated the build script and the README.

wulfgarpro commented 1 year ago

LGTM, merged.