search

meekrosoft / fff

A testing micro framework for creating function test doubles
Other
761 stars 167 forks source link

Added support for specifying calling conventions. #61

Closed wulfgarpro closed 5 years ago

wulfgarpro commented 5 years ago

This PR adds a limited capability for specification of Microsoft's Visual C/C++ calling conventions for fake signatures.

wulfgarpro commented 5 years ago

@meekrosoft, given this is my PR, I was hoping you might give it a look over?

meekrosoft commented 5 years ago

I think the feature is good. I wonder if it is possible to remove the duplication in the test files somehow with the preprocessor, but we can consider that later. I think now we have this I should set up windows continuous integration.

meekrosoft commented 5 years ago

I'm not a MSVS expert, but it looks like a versioning issue...what version of visual studio are you using? image

meekrosoft commented 5 years ago

Ah, nevermind...figured out that it needs an appveyor.yml file...I'll get that sorted out today.

meekrosoft commented 5 years ago

Actually, I could define the build environment in the UI - but probably should put it in the yaml file. https://ci.appveyor.com/project/meekrosoft/fff

wulfgarpro commented 5 years ago

Also need the tests to run.

On Fri., 23 Nov. 2018, 6:46 pm Mike Long <notifications@github.com wrote:

Actually, I could define the build environment in the UI - but probably should put it in the yaml file. https://ci.appveyor.com/project/meekrosoft/fff

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/meekrosoft/fff/pull/61#issuecomment-441172425, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6TtPlyjRzGX-uWdQMM8bMr2IBKg96qks5ux6fVgaJpZM4Yf-7T .

wulfgarpro commented 5 years ago

See: #54