search

meelgroup / approxmc

Approximate Model Counter
Other
70 stars 26 forks source link

Minimal Python Bindings for ApproxMC #26

Closed Eric-Vin closed 2 years ago

Eric-Vin commented 2 years ago

First off, thank you so much for the great tool! I'm using ApproxMC in some experiments for a paper I'm writing so I wrote some minimal Python bindings for it based off of the CryptoMiniSat ones so that I could better integrate it. I tried to follow the same style and naming conventions as well. Unfortunately, I couldn't figure out how to integrate it with your build system, but when built locally it passes a few basic tests I wrote for it.

Eric-Vin commented 2 years ago

@msoos Woops, I realized that I left a memory leak open and added a fix for that, but I forgot to add a semicolon after it so these won't actually build. It's on line 65, and once it's adding everything works as intended. Sorry about that!

msoos commented 2 years ago

I fixed it, pushed it. Unfortunately, the system is also lacking a simple README under python/, and the main README.md is also lacking a mention about the python bindings -- a shame because you put so much effort into it, let's advertise it! :)