search

meelgroup / approxmc

Approximate Model Counter
Other
70 stars 25 forks source link

Changed test to match python API and update README to match output #36

Closed alvarna closed 1 year ago

alvarna commented 1 year ago

Hi,

Thanks for the tool ! Looks like the python test was using an older API. I updated it to pass the projection set to the count function and updated the README to match the output, which is represented differently (but numerically the same).

alvarna commented 1 year ago

The update in this PR was different from #37 - This updates the example in the README in the root of the repo from Approximate count is: 88*2**13 to: Approximate count is: 11*2**16 which matches the output I get currently. These are numerically the same values, but it looks like the no. of hashes has increased, and the no. of cells has correspondingly reduced. Similarly, for the second example, the output from the current version is Approximate count is: 7*2**6 (instead of 56*2**3).

I can update the example in the python README to match this as well, if you wish. Or if you prefer to leave it with the old output, that is fine with me as well. Let me know how you would like to proceed.

msoos commented 1 year ago

Thanks this is perfect! Thanks for updating it to the currently displayed one :) Really nice! Thanks again!