search

meelgroup / approxmc

Approximate Model Counter
Other
70 stars 26 forks source link

improve error reporting for Python bindings #45

Closed fanosta closed 8 months ago

fanosta commented 8 months ago

This pull request improves the exceptions thrown by the Python bindings. (I'm creating a separate PR, because this changes the API in a minor way).

According to the Python Documentation the SystemError exception should only be thrown if the interpreter encounters an internal error. I think ValueError works better here. Also, I changed a message that was probably copy-pasted wrong.

msoos commented 8 months ago

OK, I'm releasing a new version, so new pip module will be released :)

msoos commented 8 months ago

Release will appear on PIP as module version ApproxMC 4.1.22. Thanks again!!