meelgroup / ganak

The first scalable probabilistic exact counter
MIT License
25 stars 6 forks source link

This line keeps being printed non-stop #17

Closed msoos closed 2 years ago

msoos commented 2 years ago

Here:

https://github.com/meelgroup/ganak/blob/66d056ed46bede6a9440b0d75887d2717640c147/src/instance.cpp#L305

Even though all it's paring is a valid weight, right? I have lines like:

w 37 0.500000
w 38 0.610000
w 39 0.390000
w 40 0.090000

See issue #16 for the CNF

@smsharma1 I think this is incorrect printing? Also, this parsing is incredibly fragile, I'm super afraid this will not be warning of incorrect weights. Yep, this gets parsed with exactly the same number of useless warnings:

w 38 0.610000.5