meelgroup / ganak

The first scalable probabilistic exact counter
MIT License
25 stars 6 forks source link

Trying to fix bug that affects projected counts #20

Closed msoos closed 2 years ago

msoos commented 2 years ago

This seems to fix bug in issue https://github.com/meelgroup/ganak/issues/16 It's been hacked together by Kuldeep very quickly, I'm checking it overnight. @smsharma1 can you please check if this makes sense? And can you please check if it doesn't affect the non-projected model count?

Thanks,

Mate

msoos commented 2 years ago

Merging because we can't have buggy released code and @smsharma1 couldn't respond in time to the issue or the PR.