search

meenbeese / Chronos

A simple alarm clock focused on simplicity, usability and modern design.
Apache License 2.0
66 stars 2 forks source link

Add ability to change app language #35

Closed Jean-BaptisteC closed 7 months ago

Jean-BaptisteC commented 8 months ago

Add the ability to change app language in Android settings for devices with Android 13 and upper

meenbeese commented 7 months ago

Thanks! I have some questions.

  1. Which languages are available to choose from?
  2. Why should en-GB be used, is it the default?
  3. How does it improve current language selection?
Jean-BaptisteC commented 7 months ago
  1. All languages have translations in values directories, implementing this feature can reduce the size of app, because the compiler keeps library translations only for languages specified
  2. Yes it's the default value
  3. We can't change app language in app settings, it's very useful to test different languages without changing language of the device (for example to test RTL, if in the future we support Arabic language)
meenbeese commented 7 months ago

Thanks for the contribution. Maybe we can add/improve RTL support in the future ;)