search

meenie / band.js

Band.js - Music composer interface for the Web Audio API.
Other
1.18k stars 93 forks source link

Failed to execute 'stop' on 'OscillatorNode': cannot call stop more than once. #17

Closed remotesynth closed 10 years ago

remotesynth commented 10 years ago

When I use pause() or stop() - even on existing examples that I had written with band.js and worked previously - I get the following error:

Uncaught InvalidStateError: Failed to execute 'stop' on 'OscillatorNode': cannot call stop more than once.

I cannot seem to properly unpause or replay the music.

remotesynth commented 10 years ago

Just to confirm, I get the same issue on your own Super Mario theme example.

I did some research on this and it appears that perhaps there was some changes to the spec that are causing this.

I was able to change this to get rid of the error:

if (sound.node && sound.playbackState == sound.node.PLAYING_STATE) {
    sound.node.stop(0);
}

However, when restarting (unpausing) it seems to have the version that was running and a new version started on top. Also, this seems to cause the stop() call to simply fail outright.

meenie commented 10 years ago

For some reason Github stopped sending me any email updates regarding this repository. So all of these issues and PR's that have been coming in, I had no idea about :(. Looks like I'll need to take the weekend to catch up!

With regards to this issue, I'll need some time to properly sit down and have a look. Most likely it will be this weekend.

BTW, I won't be able to make the Fluent Conference you are presenting at :(. It's just way too expensive for the flight/hotel/conference ticket. Hopefully I can get a video of your presentation though!

remotesynth commented 10 years ago

No worries. None of the issues is a show stopper (I noted that the API has changed affecting the pause and stop behavior).

The session is being recorded. Not sure when it'll be available but as soon as I know, you'll know.

Also, I'll share the slide deck if you want to see it. Wouldn't mind your feedback.

On Wednesday, March 5, 2014, Cody Lundquist notifications@github.com wrote:

For some reason Github stopped sending me any email updates regarding this repository. So all of these issues and PR's that have been coming in, I had no idea about :(. Looks like I'll need to take the weekend to catch up!

With regards to this issue, I'll need some time to properly sit down and have a look. Most likely it will be this weekend.

BTW, I won't be able to make the Fluent Conference you are presenting at :(. It's just way too expensive for the flight/hotel/conference ticket. Hopefully I can get a video of your presentation though!

Reply to this email directly or view it on GitHubhttps://github.com/meenie/band.js/issues/17#issuecomment-36820476 .

Brian Rinaldi

Web and Mobile Developers check out Flippin' Awesomehttp://flippinawesome.org Follow me Twitter @remotesynth http://twitter.com/remotesynthhttp://groups.adobe.com/people/06408603a0

meenie commented 10 years ago

Ya, I'd love to see the slide deck :). I think you already have my email address.

meenie commented 10 years ago

@remotesynth - I've fixed this issue and have released v0.3.1. Let me know if everything is okay now :).

remotesynth commented 10 years ago

Looks like everything works now. Thanks!