meenie / band.js

Band.js - Music composer interface for the Web Audio API.
Other
1.18k stars 93 forks source link

destroy leads to memory leaks #18

Closed jshthornton closed 10 years ago

jshthornton commented 10 years ago

The destroy function uses instruments = [] rather than instruments.length = 0 which causes massive memory leaks and results in jarring audio.

See: http://davidwalsh.name/empty-array

meenie commented 10 years ago

Thanks, this has been fixed :).