search

meenie / band.js

Band.js - Music composer interface for the Web Audio API.
Other
1.18k stars 93 forks source link

Fix issue #18, memory leak bug #19

Closed eugene-bulkin closed 10 years ago

eugene-bulkin commented 10 years ago

Fix memory leak caused by setting instruments = [] rather than instruments.length = 0. This is a bugfix for issue #18.

jshthornton commented 10 years ago

Cheers for adding this. I have completely changed Band.js too much to have been able to commit this change in.

meenie commented 10 years ago

Thanks @eugene-bulkin . I've since refactored the whole library, but I did use your code here: https://github.com/meenie/band.js/blob/master/src/conductor.js#L183