meenie / munee

Munee: Standalone PHP 5.3 Asset Optimisation & Manipulation

https://munee.herokuapp.com/

MIT License

833 stars 92 forks source link

Rename minify helper to minifyHelper #63

Closed vita10gy closed 9 years ago

vita10gy commented 9 years ago

Because the class is named minify PHP is attempting to construct the Minify object via the same named minify helper function

15 #62

vita10gy commented 9 years ago

uh, so did this work or not? I got green, then yellow, then red, then yellow.

meenie commented 9 years ago

Ya, the Scrutinizer is having issues with not being able to download tedious/jshrink. That's weird because that package is there and it should be available to download... I won't worry about it for now. I'll let travis pass and then go from there.

meenie commented 9 years ago

@vita10gy Where did you find out about my library, btw?

vita10gy commented 9 years ago

https://www.google.com/?gws_rd=ssl#q=php+image+optimizer (although a coworker actually found it)

meenie commented 9 years ago

Ahh, cool :)

meenie commented 9 years ago

I just installed munee and it worked fine, so I'm going to ignore Scrutinizer for this PR and just merge it in.

Thanks for your help on this!

meenie commented 9 years ago

BTW, I can't do a release at the moment because there is a bug in master that is getting fixed soon.

vita10gy commented 9 years ago

You might be able to kill this now: http://mun.ee/Known_Issues

meenie commented 9 years ago

Ya, good idea :)