meepen / pluto-inv

pluto inventory
Mozilla Public License 2.0
2 stars 10 forks source link

Added validity checks for other player in trade menu #11

Closed itsmeaddof123 closed 3 years ago

itsmeaddof123 commented 3 years ago

Some players were getting errors here (see https://imgur.com/a/qaZQRDJ) so I just added an IsValid check each time pluto.trade.Other is used.

meepen commented 3 years ago

i think the proper way is to close when a player leaves and not just check validity

itsmeaddof123 commented 3 years ago

It already does close when a player leaves, but sometimes it tries to use the player object in the tick before it closes which causes the error, so this IsValid check is just for that short span of time