meepen / salien-bot

Steam Summer Sale 2018 "Salien" minigame bot - runs in console or browser
MIT License
418 stars 104 forks source link

Show proper estimated exp per hour #104

Closed tofuBox closed 6 years ago

tofuBox commented 6 years ago

Possible fix for #90

This might not be the most elegant way to show the proper estimated exp per hour, but the maximum scores you are able to get for each level are known except for the boss level. The current maximum score set for the boss level is just an assumption.

meepen commented 6 years ago

this is very hacky and using a global variable like that is not a very good solution to the problem, i'd rather move some of the messages being shown to users down more and changing the exp_per_hour before calculating their values.

tofuBox commented 6 years ago

Yes, I do know using a global variable is not an elegant way to solve this problem.

I could move the estimated exp/hr message below, but I thought you wanted to keep the same formatting.

However I saw someone did another pull request #111 which did as how you wanted it to be.

Would you like me to continue on this?

meepen commented 6 years ago

i think if the other one works fine then you don't have to work on this anymore