meepen / salien-bot

Steam Summer Sale 2018 "Salien" minigame bot - runs in console or browser
MIT License
418 stars 104 forks source link

Code cleanup using await/async and request-promise-native #106

Closed gaspardip closed 6 years ago

gaspardip commented 6 years ago

I've been rewriting the callback hell that using promises without async/await is. I think I didn't introduce new bugs, but you are welcome to edit as needed.

Thanks for the effort btw.

callmenemo491 commented 6 years ago

JSON files don't allow comments, a way to do it is: something like: "_comment": "Comments with // or /**/ are NEVER used in a JSON file!!!",

meepen commented 6 years ago

As much as I love async/await, these features are just too new for some of the people that use this script, as well as the fact that we haven't used those yet so it would bring a few people problems, thanks for the effort and i'd love to use it but it's just too new for a lot of people.