search

meepen / salien-bot

Steam Summer Sale 2018 "Salien" minigame bot - runs in console or browser
MIT License
418 stars 104 forks source link

Stuck in loop leaving planet (Userscript Mode) #155

Closed trolloos closed 6 years ago

trolloos commented 6 years ago

It just leaves the planet and refreshes the game forever.

https://i.gyazo.com/8d21f54b40cb9f74eb589d686439c5d8.png

TheRedStormer commented 6 years ago

i am having the same problem.

trolloos commented 6 years ago

This one works for me though: https://github.com/TehDmitry/salien-bot

MatthiasMoore commented 6 years ago

This issue is related to zone 0 being the best zone on a planet resulting in some bad logic on line 122.
0 in this case is being interpreted as false, making the script believe that the planet is completed. But even after changing this, there is still some issue loading into zone 0 properly, but it is part of the solution here.

https://github.com/meepen/salien-bot/blob/d82f1a894bcd0f3fb385ba0226d8667b3ee31fe3/index.user.js#L122

I dont have much time to dive any deeper, but a quick inefficient fix is to change like 159 https://github.com/meepen/salien-bot/blob/d82f1a894bcd0f3fb385ba0226d8667b3ee31fe3/index.user.js#L159 to be if (idx == 0)

This will always ignore zone 0 and will have the UserScript working again until a proper fix is found and implemented.

Spartanul commented 6 years ago

The above does indeed work until a fix is released. Thank you! :D

meepen commented 6 years ago

Is already updated

On Sat, Jun 30, 2018, 1:50 PM Spartanul notifications@github.com wrote:

No idea how to change that. :(

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/meepen/salien-bot/issues/155#issuecomment-401556231, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5lSUTyc1ng8OSIRG0MNojf_6Z3xBMfks5uB7pJgaJpZM4U-ApL .