search

meepen / salien-bot

Steam Summer Sale 2018 "Salien" minigame bot - runs in console or browser
MIT License
417 stars 103 forks source link

the userscript on greasemonkey is not working at all #22

Open Rysanlos opened 6 years ago

Rysanlos commented 6 years ago

I don't know what to do, I installed the script, I open the mini game but nothing happens, also when I'm joining a game, the script is not working

EoD commented 6 years ago

Probably one line missing there

// @match        https://steamcommunity.com/saliengame/play/
// @match        https://steamcommunity.com/saliengame/play

instead of only

// @match        https://steamcommunity.com/saliengame/play/
meepen commented 6 years ago

sorry it's been readded

duke1102 commented 6 years ago

Same here, looks like the issue is that the userscript tries to use the gApp aka pixi before it's properly loaded.

Rysanlos commented 6 years ago

also with the last version 6 it's not working

meepen commented 6 years ago

it could be that firefox's monkey addon might load the window too quickly? i will install firefox to try and fix it

IceQ1337 commented 6 years ago

I recommend using Tampermonkey for Firefox. Greasemonkey was always a bit unreliable.

ehea617 commented 6 years ago

Works fine with Violentmonkey on Firefox.

meepen commented 6 years ago

even so, i'd like to have it compatible

Rysanlos commented 6 years ago

I installed tampermonkey on firefox, it's seems working, but not with greasemonkey :/

Js41637 commented 6 years ago

The issue is greasemonkey runs the script to fast. There is @run-at options in userscripts but I couldn't get a value where it wasn't erroring.

You'll probably need to wrap the whole function in something that waits until gApp is defined before initalizing.

ghost commented 6 years ago

working great with violentmonkey for firefox

meepen commented 6 years ago

well i've added a notification until we figure out how to support it.

Js41637 commented 6 years ago

I could get past the errors but then the script just wouldn't do anything. Greasemonkey is super confusing and so bad compared to Tampermonkey. I think it has something to do with it not having the same access to the page that tampermonkey has.

meepen commented 6 years ago

Yeah I tried the same thing and gave up as well. no clue what is happening either, added a whole try catch block and it didn't spit out errors even.

Js41637 commented 6 years ago

Well I got past the initial errors but now the script fails trying to add the ticker to PIXI (gApp) with Error: Permission denied to access object