Change skill logic. second try

[TehDmitry]

• use meteor by cooldown in center-line
• use blackhole in center-line
• use bomb if enemy hp > 30
• select more effective target for bomb
• reduce enemy scoring if they will be affected by meteor

instead #84 (I ruined branch by rebase)

[TehDmitry]

changed

[TehDmitry]

Is this changes enough?

[EoD]

@TehDmitry we are getting there! Except for the magic numbers mentioned above, is there a reason why you are overloading attack() instead of targetPosition(target)?

[TehDmitry]

@EoD because I don't have the target for Meteor and Blackhole attacks

[TehDmitry]

@EricMue in this branch I don't change coordinates for bomb attack, only enemy scoring for finding best enemy group. But you are right. Sometimes when black hole is active — bomb is missing

[EoD]

@meepen what is your take on this?

[TehDmitry]

I think we are making ideal code instead making fun

[Kefta]

ideal code is fun

[TehDmitry]

I don't know what they want. Without approving requests is no motivation to create them. For example I already have boss support

[meepen]

Ideally you should make multiple requests for the different features, suck as this and boss support, I recently started to start using user script again so I will be able to look at these changes again

On Sat, Jun 30, 2018, 10:57 AM TehDmitry notifications@github.com wrote:

I don't know what they want. Without approving requests is no motivation to create them. For example I already have boss support

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/meepen/salien-bot/pull/93#issuecomment-401546155, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5lSadQK6EekDL2S7y-4Wti1kkuXnRVks5uB5HcgaJpZM4U08GY .

[TehDmitry]

In next minigame I will try to be better. But with 7-day-long PR reviews it's a little bit hard.

Bot is outdating too fast. For example is any reason to use this ideal script without boss support instead not ideal but with support? Maybe ideal support a month later will be better?

I will remind you only two days left for fun. But #171 with most important feature is still open for 8 hour.

Seems to be too many enterprise-way for this fun game