search

meepen / salien-bot

Steam Summer Sale 2018 "Salien" minigame bot - runs in console or browser
MIT License
418 stars 104 forks source link

Added full locale support #99

Open 0xMANFRE opened 6 years ago

meepen commented 6 years ago

any thoughts on this? it adds another dependency as well as some other major changes.

EoD commented 6 years ago

@Manfre98 do you think it's worth the effort to keep locales updated? Are there bot users who do not speak English?

0xMANFRE commented 6 years ago

@EoD once a locale has been created, but in the future, there will be a string added, every locale file must have the new string name, so, it will be added in every locale file (in english). Most of the projects do the internationalization this way.

DmACKGL commented 6 years ago

Spanish: https://gist.github.com/DmACKGL/08d2416d86ec70f753e108d7e6fba919

meepen commented 6 years ago

this looks good, i will solve conflicts and merge later