search

meerk40t / svgelements

SVG Parsing for Elements, Paths, and other SVG Objects.
MIT License
132 stars 29 forks source link

Further minor tweaks to simplify __repr__ #123

Closed Sophist-UK closed 2 years ago

Sophist-UK commented 2 years ago

Yes - I see the issue. For repr you cannot have hyphens in attribute names - for str you can.

Sophist-UK commented 2 years ago

Ready for review.

Sophist-UK commented 2 years ago

I note that there are lots of raise exception statements without explanations. Before we merge this and create a new version, would you like me to go through and add explanations?

tatarize commented 2 years ago

https://github.com/meerk40t/svgelements/tree/tatarize/pr117-b

Fixed a couple of the weirder repr tests. Added SVGImage with a redirect to Image and SVGText with a direct to Text. Might be a potentially breaking change. Still fails the repr_image since it lacks a few lines.

tatarize commented 2 years ago

Additional raised crash information feels like another PR. There's also much harder housekeeping of converting most of the code to Python 3 with the typing values. Though I can likely push that off until after End-of-Life and simply do it for svgio when that I get to doing the core elements of that project.