search

meerk40t / svgelements

SVG Parsing for Elements, Paths, and other SVG Objects.
MIT License
132 stars 29 forks source link

Enable failure code for lints #144

Closed Sophist-UK closed 2 years ago

Sophist-UK commented 2 years ago

This is separate so you can merge it at whatever point you are comfortable with the lints giving failing codes.

Sophist-UK commented 2 years ago

This is good to go when Lint checks are all clean.

tatarize commented 2 years ago

Labeler is failing and apparently the code quality thing failed on start. All the nice unittests are passing though.

Sophist-UK commented 2 years ago

Lint will fail - because this PR enables the failure and there are code issues at present. If you want all the other stuff I can revert the first commit so the rest of the things work and you get a success code regardless of whether Lint finds issues.

Sophist-UK commented 2 years ago

Label I will need to look at - may have run before the merge which would have failed.

Sophist-UK commented 2 years ago

Ok - this can be merged and it will still report success even though there are Lint issues.