search

meerk40t / svgelements

SVG Parsing for Elements, Paths, and other SVG Objects.
MIT License
132 stars 29 forks source link

Add py27 unittests #147

Closed Sophist-UK closed 2 years ago

Sophist-UK commented 2 years ago

Tests fail in 2.7 on use of **kwargs after some kwargs have been explicitly specified.

Fixing this in a non-breaking way (i.e. which works when args are specified both by position and by name is a non-trivial change.

Python 2 has now been unsupported for almost 2 years, and Pip on Py2 for almost a year. Do we want to drop support for Python 2 or fix these?

tatarize commented 2 years ago

2,7 is not supported. There is an old 2.7 branch that gets no updates that was the last support it got specifically to bring bCNC up to the later versions of svgelements but that's it. Fixing the failing tests wouldn't be hard but that's supporting it. And would take writing 2 and 3 compatible code and that's a pretty clear pass.

Sophist-UK commented 2 years ago

Great - we just need to remove support for Py2 from the documentation and the Pypi definitions.