search

meeshkan / hmt

HTTP Mocking Toolkit
MIT License
52 stars 7 forks source link

Remove serve/logging.yaml #125

Closed fornwall closed 4 years ago

fornwall commented 4 years ago

Is serve/logging.yaml used or can we remove it like in this PR?

aby2s commented 4 years ago

Not sure, check if the log level is still debug for mock/record without it. Launching of either of them should output some debug level lines.

fornwall commented 4 years ago

@aby2s Just starting up, I get the below output both on master and on this branch:

$ meeshkan mock
2020-03-11 15:28:24,311 - meeshkan.serve.admin.runner - INFO - Starting admin endpont on http://localhost:8888/admin
2020-03-11 15:28:24,311 - meeshkan.serve.mock.server - INFO - Mock mock is listening on http://localhost:8000
^C
$ meeshkan record
2020-03-11 15:28:29,742 - meeshkan.serve.admin.runner - INFO - Starting admin endpont on http://localhost:8888/admin
2020-03-11 15:28:29,742 - meeshkan.serve.record.proxy - INFO - Starting Meeshkan record on http://localhost:8000
2020-03-11 15:28:29,742 - meeshkan.serve.record.proxy - INFO - Spec generation mode is disabled
^C
aby2s commented 4 years ago

Oh, we removed debug logs from startup. I think we can delete this file since we're going to change the whole log configuration in #126