search

meeshkan / unmock-js

Fuzz test your REST API calls
https://unmock.io
93 stars 8 forks source link

Polyfill Buffer when missing from global. #359

Closed ksaaskil closed 4 years ago

ksaaskil commented 4 years ago

Getting unmock run in React Native (https://github.com/unmock/unmock-react-native-example/pull/3) requires polyfilling Buffer as we depend on that somewhere via whatwg-url. Messing with global is not nice at all but I think this is the easiest solution for now to get browser support move forward.

codecov-io commented 4 years ago

Codecov Report

Merging #359 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #359   +/-   ##
=======================================
  Coverage   80.39%   80.39%           
=======================================
  Files          54       54           
  Lines        2413     2413           
  Branches      583      583           
=======================================
  Hits         1940     1940           
  Misses        473      473

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad1e314...f1cfc6c. Read the comment docs.

ksaaskil commented 4 years ago

OK to merge @carolstran ?