Closed ksaaskil closed 4 years ago
Merging #374 into dev will decrease coverage by
0.04%
. The diff coverage is77.5%
.
@@ Coverage Diff @@
## dev #374 +/- ##
=========================================
- Coverage 80.35% 80.3% -0.05%
=========================================
Files 54 55 +1
Lines 2428 2468 +40
Branches 585 592 +7
=========================================
+ Hits 1951 1982 +31
- Misses 477 486 +9
Impacted Files | Coverage Δ | |
---|---|---|
packages/unmock-server/src/server.ts | 66.21% <0%> (-0.91%) |
:arrow_down: |
packages/unmock-server/src/pid.ts | 79.48% <79.48%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5e21b98...28b329a. Read the comment docs.
unmock-server stop
command~/.unmock/server.pid
to file when unmock server is started and adding a SIGTERM handler. Stop command then reads the file and sends SIGTERM to the process./api/stop
endpoint in the mock server and also stop the proxy server there, coupling the two?server.pid
points to the wrong process? This should not happen ifstart
command gets to do its clean-up properly (defined inprocess.exit
handler)