search

meetDeveloper / Dictionary-Anywhere

Dictionary extension that helps you stay focused on what you are reading by eliminating the need to search for meaning.
GNU General Public License v3.0
267 stars 54 forks source link

Google search #18

Closed suruaku closed 4 years ago

suruaku commented 4 years ago

After using the extension for a while I noticed bunch of "define " in googles' history. I assume the extension is just googling for the definition? Even though I saw you have made API for it. However it's pretty annoying when my google history is full of those define searcher because I use the extension a lot(it is really nice).

meetDeveloper commented 4 years ago

@suruaku Hmm, I never knew that history gets populated for that, which browser are you using?

meetDeveloper commented 4 years ago

@suruaku I am not using my API, as it might get rate limited because of upstream server, and I do not want user to suffer due to API rate limit.

suruaku commented 4 years ago

I am using Firefox 77.0.1 (64-bit) from snap on Ubuntu. History looks like this.

meetDeveloper commented 4 years ago

@suruaku I have fixed this in latest version, have updated extension to v1.0.3 Basically I have omitted credentials in fetch request so that cookie does not get send and that way now your history won't be affected. You can look at this commit

suruaku commented 4 years ago

Awesome, it works. thanks a lot!

meetDeveloper commented 4 years ago

@suruaku Are you poik444 on Mozilla Addons?