search

meetDeveloper / Dictionary-Anywhere

Dictionary extension that helps you stay focused on what you are reading by eliminating the need to search for meaning.
GNU General Public License v3.0
267 stars 54 forks source link

Bugfix to move 'GOOGLE_SPEECH_URI' definition #21

Closed slay2k closed 4 years ago

slay2k commented 4 years ago

I debugged the issue of why the extension was hanging on "Searching...", especially in other languages like Spanish. This seems to have been the problem (variable undefined in scope of use), so I'm attaching a quick fix.

Tested and it works for me.

meetDeveloper commented 4 years ago

Is the meaning coming now?

meetDeveloper commented 4 years ago

Oh, noticed the mistake now, it slipped somehow.

meetDeveloper commented 4 years ago

Added a comment, little change is required and will merge it.

meetDeveloper commented 4 years ago
Screenshot 2020-07-18 at 1 10 38 AM

I have updated the extension, it will be available shortly. Thank you for your contribution. I appreciate it a lot. @slay2k

meetDeveloper commented 4 years ago

@slay2k Updated extension v1.0.6 is now available on website, can you check it once? Sorry for the inconvenience.

slay2k commented 4 years ago

Yup, works now!