search

meetDeveloper / Dictionary-Anywhere

Dictionary extension that helps you stay focused on what you are reading by eliminating the need to search for meaning.
GNU General Public License v3.0
253 stars 53 forks source link

Great extension/add-on #23

Open syverik opened 3 years ago

syverik commented 3 years ago

Need whitelist the url(s) for my ad block, if possible please list them n would be highly appreciative. By for now

webster

meetDeveloper commented 3 years ago

@syverik are you the one with slashdot website problem?

syverik commented 3 years ago

Well you are a smart person, and yes I am

meetDeveloper commented 3 years ago

@syverik Looking into this. Is this problem only experienced when you turn on adblock?

syverik commented 3 years ago

Yes, I recently switched uBlock Origin and have the same problem persists, only on this site(slashdot) that I have noticed so far. If I turn off completely and wait the extra for the ads load then I can see the definitions on slashdot using your amazing, flabbergasting add-on

meetDeveloper commented 3 years ago

@syverik Hmm, i noticed that when i turned off the ublock origin and then reload the page, the popup shows, but if I turned on it does not show. You waited for ads to show when you turned off ublock origin without reloading the page right?

syverik commented 3 years ago

Correct

syverik commented 3 years ago

ublock on = does not work ublock off = does work

meetDeveloper commented 3 years ago

I found the cause, that some css style sheet that ublock origin apply to slashdot makes the display none for my addon.

syverik commented 3 years ago

And I'm taking it there is no work around? Appreciate you looking into this, shall still use your add-on for other stuff

meetDeveloper commented 3 years ago

There is a way, ideally this should not have happened as I am using shadow DOM so styling from outside should not have bleed in. But somehow this is happening, I need to find out why.

I will look into this closely and promise a fix soon. Sorry for the inconvenience.

syverik commented 3 years ago

Much respect for what you are doing, almost like you are reinventing the pencil with this app. Don't know how to say how much easier this makes learning new words for me. Was reading Webster, more recently highlighting and searching on the googol or using my voice for those alexa or nest hubs while reading many a book(of forgotten lore :P) so I don't waste so much finding a word that I've already felt just haven't had the words. So thanks again!!!

meetDeveloper commented 3 years ago

@syverik Thanks a lot :)

meetDeveloper commented 3 years ago

@syverik Can you try now and let me know, it should now be working. Sorry for very late reply, I fixed these kind of issues few days back and was now trying on this website, and now it was working.