Do not rely on Google's automated generated classes

meetDeveloper / Dictionary-Anywhere

Dictionary extension that helps you stay focused on what you are reading by eliminating the need to search for meaning.

GNU General Public License v3.0

253 stars 53 forks source link

Do not rely on Google's automated generated classes #6

Closed huytd closed 4 years ago

huytd commented 4 years ago

Fixes #5

We're relying on Google's automated generated class names for getting explanation text.

These classes (.PNlCoe) are never a reliable thing, and I just noticed that looking for data-dobid=dfn itself is enough, as we just need to take the first explanation.

meetDeveloper commented 4 years ago

@huytd I have changed the code, to include this before, I have not updated the repository will do it today itself, thank you for your work, it feels good when people shows such enthusiasm to take the thing you build forward.

huytd commented 4 years ago

Thanks @meetDeveloper! Let me close this PR then.