meetDeveloper / Dictionary-Anywhere

Dictionary extension that helps you stay focused on what you are reading by eliminating the need to search for meaning.
GNU General Public License v3.0
253 stars 53 forks source link

[Feature Request] Langauge selection #7

Open HubKing opened 4 years ago

HubKing commented 4 years ago

I was looking for the Chrome's "Google Dictionary" equilvalent. It seems that this add-on is showing the same data as the official Google extension. However, Google's one automatically detects foreign languages and shows English translation for that, while this addon shows "Sorry" or a wrong definition, etc.

Google's image image

This add-on image image

I guess the auto-detection must be difficult. Then, how about let the user pre-define a few languages he often uses, and show radioboxes for them at the top of the pop-up window? For example, in my case, I could set "English, French" and when it shows "Sorry" for "Loup", I could click the French radiobox and see the French definition or translation for it.

meetDeveloper commented 4 years ago

@HubKing I will implement global language setting this weekend. And whereas the setting to show radio button in popup, I have to think about that.

meetDeveloper commented 4 years ago

@HubKing Added language selection, currently language available other than English are, Spanish, German, French. Check if that works for you.

HubKing commented 4 years ago

Thanks for your work. The default language option is just like Google's own extension, and it is useful it its way. But this does not help in my case.

The reason is that there two words of different languages could have the exact same spelling. Google's Dictionary extension seems to determine the language based on the context (I don't know how they do that, maybe A.I or something), and I need to view the definitions for both English and French words. So, I hoped that there would be language radio boxes on the dictionary bubble itself. like this: fr This way, I could manually select the language dynamically. Even Google's extension sometimes wrongly determines the word's language, so having the ability to manually override the language detection would be helpful.

And one minor cosmetic bug is that the drop-down is displayed in a wrong position. image

PS: By the way, "pays" means "a country" in French, not "to pay".

meetDeveloper commented 4 years ago

@HubKing The drop down is actually shown correctly, I have tried it, can you try again?

meetDeveloper commented 4 years ago

@HubKing Your point about the language is correct, I will add these soon.