search

meetecho / asterisk-opus

Opus (transcoding) and VP8 (passthrough) support for Asterisk, needed for a better WebRTC integration
GNU General Public License v2.0
77 stars 84 forks source link

Loss Concealment #12

Open kelchy opened 9 years ago

kelchy commented 9 years ago

Hi,

I noticed that this patch does not compensate for lost packets. May I know the reason why? according to opus API, you should use opus_decode with null pointer when lost packets are detected. Is this something not needed? will quality be improved if we do this?

lminiero commented 9 years ago

Not sure we can figure out lost packets from within a codec plugin: all methods are invoked by the Asterisk core, and so we wouldn't be able to understand if and when a packet is lost.

Dimitripietro commented 9 years ago

Hi,

From what I understand, one of the major feature of Opus is PLC. Using this patch Asterisk/opus is not compensating for lost packet at all ? That mean a conversation with 1% packets loss using Opus will have the same quality than the same 1% packets loss with G711 for example ?