Implement mute/unmute room and add offer to join

meetecho / janode

A Node.js adapter for the Janus WebRTC server

ISC License

98 stars 36 forks source link

Implement mute/unmute room and add offer to join #12

Closed golgetahir closed 2 years ago

golgetahir commented 2 years ago

Hi team, thanks for the implementation helped me greatly. Though in the audio bridge plugin, there are some events not there so I added mute/unmute with event callback to peers and generate_offer flag to join room. I am sharing this PR with you hoping that it will be merged or help in any way. Thanks a lot for great work!

golgetahir commented 2 years ago

@atoppi Thanks for the review, I think I have done it accordingly now.

atoppi commented 2 years ago

Thanks looks good now! I'll merge it once I have the chance to check that everything works as expected.

golgetahir commented 2 years ago

Thanks for review, changes are done.

atoppi commented 2 years ago

fyi in https://github.com/meetecho/janode/commit/903cd75b285ef160e646bba1138ddbdc5c611437 I have also added the sample code for this feature and corrected some indentation issues. Thanks again!