Make Janode an ES module - Githubissues

meetecho / janode

A Node.js adapter for the Janus WebRTC server

ISC License

98 stars 36 forks source link

Make Janode an ES module #2

Closed atoppi closed 2 years ago

atoppi commented 2 years ago

We'll track here the migration of the library from CJS module to ES module. ~~Once #1 will be merged, this branch will probably need some more work.~~ (done)

!!! Breaking changes !!!

cjs apps will not work anymore, please migrate to esm
node engine minimum version is now v14.13.1

How to migrate to ESM

Read Node documentation about esm
Warning: strict mode is always enforced in es mode
Warning: __filename and __dirname globals are not defined in es mode
Set type: module and exports entry point in your package.json
Convert any require call into the equivalent import directive
Convert any module.exports call into the equivalent export / export default directive

Changes in the browser bundling sample

Since browserify does not support esm, we switched to rollup with a bunch of plugins (check bundle.sh)
The global exported variable is now named App