search

meetecho / janode

A Node.js adapter for the Janus WebRTC server
ISC License
98 stars 36 forks source link

videoroom: add "admin_key" parameter to list API #37

Closed OverSamu closed 8 months ago

OverSamu commented 8 months ago

Before https://github.com/meetecho/janode/commit/28d019cd263602cfd35e8c118f8af88302c3a47b I didn't know it was possible to pass "admin_key" parameter to list requests to also get private records, interesting. For the same reason I made the same change in videoroom, since it's also supported by this plugin.

Thank you!

lminiero commented 8 months ago

It should be noted that Streaming and TextRoom plugin have this property too (although IIRC TextRoom is not supported by Janode yet).

atoppi commented 8 months ago

@OverSamu can you please add the parameter also to create and stopForward ?

atoppi commented 8 months ago

Thanks! Merging.

OverSamu commented 8 months ago

Hi, when will these changes be released? Thank you

atoppi commented 8 months ago

In the next release, but not sure when I'll publish it. If you are using janode in a package.json dependency you could still point to specific commit hash from github instead of pointing to npm releases.