Typo/out of scope variable in mvideoroomtest.js

meetecho / janus-gateway

Janus WebRTC Server

https://janus.conf.meetecho.com

GNU General Public License v3.0

8k stars 2.45k forks source link

Typo/out of scope variable in mvideoroomtest.js #1554

Closed qmohammed93 closed 5 years ago

qmohammed93 commented 5 years ago

https://github.com/meetecho/janus-gateway/blob/4c9bbdd164b28277cd17a4bffcdd5729f1d5bf53/html/mvideoroomtest.js#L260

It appears there's a typo here as we are trying to unsubscribe from the variable "leaving" which is undefined in this scope, shouldn't it be unsubscribeFrom(unpublished) over here?

lminiero commented 5 years ago

Good catch, yes that's a typo. Unfortunately I don't have connectivity at home right now: I'm answering from my phone. I'll fix this when it gets back.

lminiero commented 5 years ago

Fixed.