meetecho / janus-gateway

Janus WebRTC Server

https://janus.conf.meetecho.com

GNU General Public License v3.0

8k stars 2.45k forks source link

Crash after commit a0240a1 #1586

Closed amnonbb closed 5 years ago

amnonbb commented 5 years ago

1459

After last commit, Janus crash if I use DataChannel in videoroom. In every crash the dump is same: https://pastebin.com/63NFbkgv

It's happen (but not always) when publisher join in room.

lminiero commented 5 years ago

Looks like it crashes when unlocking a mutex, so no idea on the cause. You should try compiling with libasan support to see if the cause is a freed pointer.

amnonbb commented 5 years ago

https://pastebin.com/Zbs6NPuV

lminiero commented 5 years ago

Ah ok, another unlock without a lock... I'll have to check what the path that leads to it might be.

lminiero commented 5 years ago

I'm pretty sure this commit fixes it: https://github.com/meetecho/janus-gateway/pull/1459/commits/43aeb9134800cc724f10407f24b5ea84177963e0 There was an extra unlock that could happen inside a while (indeed related to datachannels), which could still lead to the mean unlock in the for, and I guess that's what was happening to you.

Closing, feel free to reopen if still an issue.