Segmentation fault in audiobridbe plugin

meetecho / janus-gateway

Janus WebRTC Server

https://janus.conf.meetecho.com

GNU General Public License v3.0

8.23k stars 2.48k forks source link

Segmentation fault in audiobridbe plugin #1923

Closed chpl closed 4 years ago

chpl commented 4 years ago

Janus built from v0.7.6 tag dependencies: { "glib2": "2.50.3", "jansson": "2.9", "libnice": "0.1.16", "libsrtp": "libsrtp2 2.2.0", "crypto": "OpenSSL 1.1.0l 10 Sep 2019" }

https://pastebin.com/wx9qvSQr

Happens when participant leave room before media is ready

lminiero commented 4 years ago

Please test master, I don't debug older versions.

lminiero commented 4 years ago

The commit above should fix it: there was a missing check on whether the participant's room was NULL, and it was dereferenced anyway, hence your crash.