search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.15k stars 2.47k forks source link

Segfault #1970

Closed enhany closed 4 years ago

enhany commented 4 years ago

VideoRoom will segfault on line 6294 simetimes. https://github.com/meetecho/janus-gateway/blob/master/plugins/janus_videoroom.c#L6294

When I create new subscriber with close_pc=false. After this, publisher leave the room. And I send 'configure' request for subscriber with update=true, then videoroom will segfailt.

enhany commented 4 years ago

Another situation: create subscriber with close_pc:false, join the room, then send 'leave' and 'configure'with update=true requests in a row.

coredump on the same line as above.

lminiero commented 4 years ago

Thanks, we'll have a look ASAP :+1:

lminiero commented 4 years ago

The commit above should fix it. Notice that when you have close_pc: false, the publisher leaves and then you ask for an update, the expected result is that nothing will happen: the PeerConnection will NOT be renegotiated.

enhany commented 4 years ago

@lminiero yes, it's ok, PeerConnection will not be renegotiated. Expected result in this case - janus will not crash :)