Closed veeting closed 1 year ago
Thanks for your contribution, @veeting! Please make sure you sign our CLA, as it's a required step before we can merge this.
Thanks, @atoppi
Your short hand writing is nicer, however, I tried to be consistent with similar checks which already exist in master, for instance:
https://github.com/meetecho/janus-gateway/blob/master/html/janus.js#L1928
Would you prefer me to
I am happy with all, however, I would prefer 1 or 3, to keep the code consistent.
I see. Okay, let's keep the code consistent: option no. 1
Merging then, thanks! I'll check if the same fix needs to be packported to 0.x
.
Hi Lorenzo,
We have recently seen some exceptions in our logs that indicate that config.pc was null when trying to call getTransceivers(). We don't know why it is happening, from the logs it seams to only happen on Android devices so far.
This PR adds three null checks to mitigate this potential issues.
Kind regards,
Fabian