Closed jwittner closed 1 year ago
Thanks for your contribution, @jwittner! Please make sure you sign our CLA, as it's a required step before we can merge this.
I was able to get echo.py to mimic my doubled up messages and test these changes. My message with two requests (full transactions each) both succeeded. I tested the error path and see good logs about the json formatting reported.
All the feedback should be addressed now. Please re-review @lminiero when you can - thanks!
Alright, all feedback should be addressed. @lminiero / @tmatth - let me know if there's anything else needed to get this merged. And thanks for all the help!
Can either of you approve the workflow so I can feel certain about the build/tests?
Alright, all comments resolved and tests are passing. Let me know if there's anything else.
Also, once merged, should I move to 0.x or will y'all be doing that?
Also, once merged, should I move to 0.x or will y'all be doing that?
Looks like the patch should be easy enough to apply cleanly to 0.x
too, so I can do it myself after this is merged.
Great! Anything holding this back? Not sure what the flow is for the project on merging PRs. =)
I'll need time to review and test, so please bear with me 🤠I'm also busy on a few other activities so I may need a couple of days.
I'll need time to review and test, so please bear with me 🤠I'm also busy on a few other activities so I may need a couple of days.
No problem at all! Thanks again for all the help. If there are any tests I can write to help out, do let me know!
Looks good to me! I'll merge and backport it to 0.x
now :v:
Thanks for your contribution and your patience!
Resolves #3120