search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.25k stars 2.48k forks source link

Update type definition #3125

Closed jerry4718 closed 1 year ago

januscla commented 1 year ago

Thanks for your contribution, @jerry4718! Please make sure you sign our CLA, as it's a required step before we can merge this.

lminiero commented 1 year ago

There's a lot of changes here. Can you please elaborate on what led you to come up with these changes, and explain them? Thanks!

jerry4718 commented 1 year ago

I'm trying to encapsulate Janus's functions based on Promise, so I found that some functions are not in the type definition file. I added these changes to my own project, which may be useful for others

---Original--- From: "Lorenzo @.> Date: Wed, Dec 14, 2022 21:44 PM To: @.>; Cc: @.**@.>; Subject: Re: [meetecho/janus-gateway] Update type definition (PR #3125)

There's a lot of changes here. Can you please elaborate on what led you to come up with these changes, and explain them? Thanks!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

lminiero commented 1 year ago

Pinging @atoppi as this is beyond my poor JS skills :hand_over_mouth:

jerry4718 commented 1 year ago

Thanks for the effort! I've left some comments.

I am really sorry that I have so many negligence, then I will address these points in detail next, thanks for the review

lminiero commented 1 year ago

Thanks, merging then!

Pratikh commented 1 year ago

Hi

We are using Janus in our project with TS so just wanted to know how can use type definition which you defined?

Janus is awesome Thanks @lminiero