meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.25k stars 2.48k forks source link

[1.x] Error when make in ubuntu 20.04 version #3181

Closed kschoi93 closed 1 year ago

kschoi93 commented 1 year ago

Error when make in ubuntu 20.04 version

$ make

... netinet/sctp_output.c: In function 'sctp_med_chunk_output': netinet/sctp_output.c:9023:6: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] 9023 | use_zero_crc = asoc->zero_checksum = 2; | ^~~~ cc1: all warnings being treated as errors make[1]: [Makefile:719: netinet/libusrsctp_la-sctp_output.lo] Error 1 make[1]: Leaving directory '/home/usrsctp/usrsctp/usrsctplib' make: [Makefile:409: all-recursive] Error 1


$ vi usrsctplib/netinet/sctp_output.c
9023 G
                                        use_zero_crc = asoc->zero_checksum = 2;
                                        if (asconf) {
                                                sctp_timer_start(SCTP_TIMER_TYPE_ASCONF, inp, stcb, net);
                                                use_zero_crc = false;
                                                /*
                                                 * do NOT clear the asconf
                                                 * flag as it is used to do
                                                 * appropriate source address
                                                 * selection.
                                                 */
                                        }

edit code

use_zero_crc = asoc->zero_checksum = 2; -> use_zero_crc = asoc->zero_checksum == 2;


I do not speak English well. And this is the first issue registration.

An error occurred when building using make, and it seems to need to be fixed, so I uploaded it to the issue registration.

lminiero commented 1 year ago

It's an issue in usrsctp, not Janus. See https://github.com/sctplab/usrsctp/issues/671

kschoi93 commented 1 year ago

I understand, thank you for explaining!