search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

[1.x]maybe janus_videoroom_subscriber_stream_free bug #3190

Closed openspring closed 1 year ago

openspring commented 1 year ago

What version of Janus is this happening on? version 1.1.3

Additional context janus_videoroom.c

When the following test conditions are added to the janus_videoroom_subscriber_stream_free func JANUS_LOG(LOG_VERB, "videoroom janus_videoroom_subscriber_stream_free\n"); When someone exits, you will not see the stream deleted

The possible cause of the problem is in the janus_videoroom_subscriber_stream_add function

janus_refcount_increase(&stream->ref); / This is for the mid-indexed hashtable / in this line

When subcriber is deleted, the stream->ref is not deleted

atoppi commented 1 year ago

I'm unable to reproduce on master (tested both videoroom and multistream videoroom demos).

openspring commented 1 year ago

This error is caused by my changes, this is a misunderstanding