search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

[1.x] any reason for switch to not have substream param? #3196

Closed brave44 closed 1 year ago

brave44 commented 1 year ago

In videoroom plugin, switch command doesn't have substream param, as subscribe or configure command have (https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_videoroom.c#L9428). Simulcast just resets on switching (https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_videoroom.c#L11237 ).

It forces us to do configure to needed substream every time we doing switch, not ideal, especially if room have many streams.

Is it some specific reason to such implementation is switch, or it's just not implemented? Can we do PR with this logic?

lminiero commented 1 year ago

No specific reason: I think we recently fixed the simulcast configuration in multistream VideoRoom, and probably just forgot to do the same for switch too. A pull request would indeed be welcome: please notice I'll be abroad in vacation the whole week, so I may be very slow to review until I'm back.

lminiero commented 1 year ago

Merged.