search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.25k stars 2.48k forks source link

[1.x] Support for batched configure requests in Streaming Plugin #3238

Closed petarminchev closed 1 year ago

petarminchev commented 1 year ago

We are very happy with the batch configure request in VideoRoom plugin - https://github.com/meetecho/janus-gateway/pull/2986. For scaling purposes we rtp_forward to the Streaming Plugin. It would make our lives a lot easier if Streaming plugin supported batched configure requests. It is especially useful during paging - instead of sending dozens of requests to Janus, we will send only one configure request - which streams to be send: true/false. Also by looking at the VideoRoom pull request, it doesn't seem like a huge effort. Could you consider adding batched configure requests to Streaming Plugin? We think it is a very valuable feature.

Thank you in advance!

lminiero commented 1 year ago

Well that patch wasn't small, and the Streaming plugin works a bit differently from the VideoRoom -- I wouldn't call it a "small effort" :stuck_out_tongue: I can add it to the todo list but not sure when I'll have time to do that. I'd obviously be happy to review a pull request that implements this feature too.

petarminchev commented 1 year ago

@lminiero - Created a pull request - https://github.com/meetecho/janus-gateway/pull/3239. Seems to work for us, but of course you need to review it.

lminiero commented 1 year ago

Thanks! I'll try to do it later today.