search

meetecho / janus-gateway

Janus WebRTC Server
https://janus.conf.meetecho.com
GNU General Public License v3.0
8.17k stars 2.47k forks source link

Batch configure support for streaming plugin #3239

Closed petarminchev closed 1 year ago

petarminchev commented 1 year ago

Supporting a streams array param to configure multiple mids in one batch request.

januscla commented 1 year ago

Thanks for your contribution, @petarminchev! Please make sure you sign our CLA, as it's a required step before we can merge this.

petarminchev commented 1 year ago

Added streams array to the doxygen part of the code.

lminiero commented 1 year ago

@petarminchev thanks! I'll make a couple of tests later today, and I've launched the CI checks on the branch too. I noticed you haven't signed the CLA though? Please do that at your earliest convenience, since without that step I can't merge this.

petarminchev commented 1 year ago

The COO of DigitalSamba has already signed the CLA, I suppose that should be enough? Do you see the signed CLA by him?

lminiero commented 1 year ago

It must be signed by you: you're the author of the patch.

petarminchev commented 1 year ago

Signed it

lminiero commented 1 year ago

Sorry for the lack of feedback! I plan to make a couple of tests later today and merge in case it's fine :+1:

lminiero commented 1 year ago

Made a few tests with a multistream mountpoint with multiple simulcast video streams, and it does seem to work as expected :+1: I vedified that a "legacy" configure request with no mid seems to be enforced on all streams, which means it is backwards compatible too. Merging then, thanks again!